Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vae training and autovae #11592

Merged
merged 5 commits into from
Dec 31, 2024
Merged

vae training and autovae #11592

merged 5 commits into from
Dec 31, 2024

Conversation

linnanwang
Copy link
Contributor

@linnanwang linnanwang commented Dec 13, 2024

What does this PR do ?

this PR introduces VAE training into NeMo that allows users to customize a 16x or 8x reduction VAE on their in house data. Besides, we also introduce a feature that automatically designs VAE based on the GPU memory and latency requirements.

Collection: NeMo/Diffusion/VAE

Changelog

  • it is a new feature, no touch of existing codes.

Usage

  • Please follow the readme to setup the training.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • [Yes] Make sure you read and followed Contributor guidelines
  • [No] Did you write any new necessary tests?
  • [Yes] Did you add or update any necessary documentation?
  • [No] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • [No] Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature

Signed-off-by: linnan wang <[email protected]>
@ethanhe42 ethanhe42 self-requested a review December 14, 2024 01:04
ethanhe42
ethanhe42 previously approved these changes Dec 14, 2024
Comment on lines +55 to +57

self.discriminator = NLayerDiscriminator(
input_nc=disc_in_channels, n_layers=disc_num_layers, use_actnorm=use_actnorm

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
Signed-off-by: linnan wang <[email protected]>
@linnanwang linnanwang changed the title vae training vae training and autovae Dec 16, 2024
@ethanhe42 ethanhe42 enabled auto-merge (squash) December 30, 2024 17:14
@pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay disabled auto-merge December 31, 2024 19:18
@pablo-garay pablo-garay merged commit b73bfff into NVIDIA:main Dec 31, 2024
14 checks passed
@linnanwang
Copy link
Contributor Author

@pablo-garay @ethanhe42 thanks!

abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* vae training

Signed-off-by: linnan wang <[email protected]>

* vae training

Signed-off-by: linnan wang <[email protected]>

---------

Signed-off-by: linnan wang <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants